To avoid hanging test case, always mine until txpool empty #4122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hanging test case in aecore_forking_SUITE manifested as follows (from log on dev1):
The assumption is that the preceding test case, mining exactly one microblock on dev2, didn't empty the mempool, after which, the following test case would wait endlessly (= until time trap) for its mempool to become empty.
This change ensures that dev2 keeps producing microblocks as long as there is something in its mempool.