HC: Lazy leader #4183
Merged
HC: Lazy leader #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanhinde
reviewed
Aug 10, 2023
seanhinde
reviewed
Aug 10, 2023
seanhinde
reviewed
Aug 10, 2023
| {error, not_leader}; | ||
| ok -> | ||
| {ok, Leader} | ||
| end; | ||
| {error, What} -> |
There was a problem hiding this comment.
Does this have an eventual timeout somewhere or will it carry on forever?
There was a problem hiding this comment.
I would guess no timeout - we don't timeout on trying to find a PoW solution either. Also the next leader is being elected by a contract and could use some block time in its calculations so if Alice is not a leader now, she could be in 10 seconds.
seanhinde
reviewed
Aug 10, 2023
seanhinde
reviewed
Aug 10, 2023
uwiger
reviewed
Aug 11, 2023
| @@ -202,7 +214,7 @@ post_request(Path, Body, Host, Port, Timeout) -> | |||
| {ok, {{_, 200 = _Code, _}, _, Res}} -> | |||
| lager:debug("Req: ~p, Res: ~p with URL: ~ts", [Req, Res, Url]), | |||
| {ok, jsx:decode(list_to_binary(Res), [return_maps])}; | |||
| {ok, {{_, 400, _}, _, Res}} -> | |||
| {ok, {{_ ,400, _}, _, Res}} -> | |||
uwiger
approved these changes
Aug 11, 2023
dincho
added
kind/feature
mitchelli
pushed a commit
that referenced
this pull request
Jan 22, 2024
HC Lazy leader implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3929
The work on this PR has been supported by ACF.