Add endpoint to get recent gas prices #4191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
commented
Aug 23, 2023
| end, | ||
| [BlockAmount, GasPrice] | ||
| end, | ||
| [1, 5, 20, 120, 480]). |
There was a problem hiding this comment.
It should be 3 minutes, 15 minutes, 1 hour, 6 hours, and 1 day respectively.
davidyuk
force-pushed
the
recent-gas-prices
branch
from
44dfa9a
to
282d7a3
Compare
hanssv
reviewed
Nov 6, 2023
|
I had a plan to calculate it once for a generation, but it is too difficult. Maybe someone can take over this PR? 🙏 This is more POC and API needed for sdk. |
|
Replaced by #4277. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed to implement aeternity/aepp-sdk-js#1786
At some point, we would have a such blockchain load that won't allow us to mine all submitted transactions with the minimum fee. Then the gas price used to build a transaction would matter. To be able to estimate a reasonable gas price I'm proposing to implement an endpoint on the node side exposing the minimum gas price among the last blocks.
This PR is supported by the Æternity Crypto Foundation