Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show api docs and version #105

Merged
merged 1 commit into from Oct 20, 2021
Merged

Conversation

AtanasKrondev
Copy link
Contributor

@marc0olo
Copy link
Contributor

closes #99

Copy link
Contributor

@marc0olo marc0olo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks generally good to me. what kind of style do you prefer? when using the paragraph for the version number the text is too big IMO.

either we change that somehow or you just use my suggestion 😅

Comment on lines 46 to 66
<div class="footer mobile">
<a
:href="apiDocs"
target="_blank"
>
æternity middleware docs
</a>
<p>{{ mdwVersion }}</p>
</div>
</AppNavAccordion>
<div class="footer desktop">
<a
:href="apiDocs"
target="_blank"
>
æternity middleware docs
</a>
<p>{{ mdwVersion }}</p>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="footer mobile">
<a
:href="apiDocs"
target="_blank"
>
æternity middleware docs
</a>
<p>{{ mdwVersion }}</p>
</div>
</AppNavAccordion>
<div class="footer desktop">
<a
:href="apiDocs"
target="_blank"
>
æternity middleware docs
</a>
<p>{{ mdwVersion }}</p>
</div>
<div class="footer mobile">
<a
:href="apiDocs"
target="_blank"
>
API docs
</a>
<br>
{{ mdwVersion }}
</div>
</AppNavAccordion>
<div class="footer desktop">
<a
:href="apiDocs"
target="_blank"
>
API docs
</a>
<br>
{{ mdwVersion }}
</div>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it more like this :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, its' much better :)

Copy link
Contributor

@marc0olo marc0olo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AtanasKrondev AtanasKrondev merged commit 0a86e68 into master Oct 20, 2021
@AtanasKrondev AtanasKrondev deleted the feature/show-api-ref branch October 20, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants