New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show api docs and version #105
Conversation
AtanasKrondev
commented
Oct 15, 2021
closes #99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks generally good to me. what kind of style do you prefer? when using the paragraph for the version number the text is too big IMO.
either we change that somehow or you just use my suggestion 😅
partials/appMainNav.vue
Outdated
<div class="footer mobile"> | ||
<a | ||
:href="apiDocs" | ||
target="_blank" | ||
> | ||
æternity middleware docs | ||
</a> | ||
<p>{{ mdwVersion }}</p> | ||
</div> | ||
</AppNavAccordion> | ||
<div class="footer desktop"> | ||
<a | ||
:href="apiDocs" | ||
target="_blank" | ||
> | ||
æternity middleware docs | ||
</a> | ||
<p>{{ mdwVersion }}</p> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div class="footer mobile"> | |
<a | |
:href="apiDocs" | |
target="_blank" | |
> | |
æternity middleware docs | |
</a> | |
<p>{{ mdwVersion }}</p> | |
</div> | |
</AppNavAccordion> | |
<div class="footer desktop"> | |
<a | |
:href="apiDocs" | |
target="_blank" | |
> | |
æternity middleware docs | |
</a> | |
<p>{{ mdwVersion }}</p> | |
</div> | |
<div class="footer mobile"> | |
<a | |
:href="apiDocs" | |
target="_blank" | |
> | |
API docs | |
</a> | |
<br> | |
{{ mdwVersion }} | |
</div> | |
</AppNavAccordion> | |
<div class="footer desktop"> | |
<a | |
:href="apiDocs" | |
target="_blank" | |
> | |
API docs | |
</a> | |
<br> | |
{{ mdwVersion }} | |
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it more like this :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, its' much better :)
41dd997
to
f05755c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm