Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong number of NA rows in the output? #386

Closed
aborruso opened this issue Mar 13, 2023 · 3 comments
Closed

Wrong number of NA rows in the output? #386

aborruso opened this issue Mar 13, 2023 · 3 comments
Assignees
@aeturrell
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
0.0.9

Comments

@aborruso
Copy link

aborruso commented Mar 13, 2023 •
edited

Hi,
first of all thank you for this great tool.

If I run skimpy on this 999 rows CSV I have 1000 NA rows.

Thank you

image
@aborruso aborruso changed the title Wrong number of rows in the output? Wrong number of NA rows in the output? Mar 13, 2023
@aeturrell
Copy link
Owner

aeturrell commented Mar 13, 2023 •
edited

Huh, that's strange! I will look into it.

@aeturrell aeturrell added the bug Something isn't working label Mar 13, 2023
@aeturrell aeturrell self-assigned this Mar 13, 2023
@aeturrell
Copy link
Owner

This is occurring because _round_dataframe applies to all numeric columns, regardless of whether or not they are integers. This has some unfortunate consequences, such as rounding 988 to 990, 999 to 1000, and so on. As a solution, rounding should probably only be applied to specific columns that need it, ie it should be applied within the type-specific functions (eg _string_variable_summary_table) to only the relevant columns.

@aeturrell aeturrell added the good first issue Good for newcomers label Jul 16, 2023
@aeturrell aeturrell added this to the 0.0.9 milestone Jul 16, 2023
@aeturrell aeturrell mentioned this issue Jul 16, 2023
Closed
aeturrell added a commit that referenced this issue Jul 16, 2023
@aeturrell
closes #454, #386
ffd2a68
aeturrell added a commit that referenced this issue Jul 16, 2023
@aeturrell
Merge pull request #456 from aeturrell/nans
650c830 
closes #454,  #386
@aborruso
Copy link
Author

I didn't remember this issue
Thak you very much @aeturrell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeturrell aeturrell

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
0.0.9
Development

No branches or pull requests
2 participants
@aborruso @aeturrell