Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the length of violet noise samples-1? #74

Closed
jondoesntgit opened this issue Sep 6, 2018 · 1 comment
Closed

Why is the length of violet noise samples-1? #74

jondoesntgit opened this issue Sep 6, 2018 · 1 comment

Comments

@jondoesntgit
Copy link

It's easy enough to correct on my end, but it seems inconsistent.

https://github.com/aewallin/allantools/blob/master/tests/functional_tests/test_noise.py

@aewallin
Copy link
Owner

aewallin commented Sep 7, 2018

Looks like diff( random(num_points) ) could be changed to diff( random(num_points+1) ) over here
https://github.com/aewallin/allantools/blob/master/allantools/noise.py#L71

I agree that for consistency all noise-functions should return the same number of points.
Another questions is if we want to keep all the individual noise-generators or use Kasdin&Walter for everything?

@aewallin aewallin mentioned this issue Jul 8, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants