conditionally required field, requiredWhen validator spec #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heavily inspired by @neezer, #78, and #81
How it works:
instead of validate requirement based on raw env, we clean the env, then check if it is required.
requiredWhen is a boolean function that takes cleaned env then returns if the field is required.
I think this would get rid of most of the problems by using cleaned env instead of raw.
let me know what you think :)
(this is actually my first few PR outside of university, so I'm sorry if I've done anything wrong)