Improved tests for default values #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 23, 2015 17:22
Otherwise, only one test suite could check validationErrors. Because all test suite definitions are run before any of the test cases start, so if env.onError was set in more than one suite, each suite would replace the previous suite's handler. This seems better than putting a require() in each test suite.
At first it seems like we could test for validationErrors.length == 0 in cases where input passes all the tests. But that's not quite correct, because validationErrors is only populated as a side-effect when the onError handler is called. It never exists if there are no errors. Instead, we actually need to test whether the onError handler is called. So we clear a boolean before each test, then enable it from onError. Of course, this required some of the test cases to be split up, which also led to slightly clearer naming. This edge case is unique to asynchronous programming because a normal function will either return or throw an exception. It probably would have been cleaner to use a node-style callback that is called exactly once and has the signature function(error, result).
|
Rebased and merged this from the CLI. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves on the tests for
defaultvalues. This is a superset of the changes in #4. Additions include: