Skip to content

Commit

Permalink
target-s390x: Introduce QOM realizefn for S390CPU
Browse files Browse the repository at this point in the history
Introduce realizefn and set realized = true in cpu_s390x_init().

Defer CPU reset from initfn to realizefn.

Acked-by: Richard Henderson <rth@twiddle.net>
[AF: Invoke parent's realizefn]
Signed-off-by: Andreas Färber <afaerber@suse.de>
  • Loading branch information
afaerber committed Feb 7, 2013
1 parent 4d38e6b commit b4e4147
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 3 deletions.
2 changes: 2 additions & 0 deletions target-s390x/cpu-qom.h
Expand Up @@ -34,6 +34,7 @@

/**
* S390CPUClass:
* @parent_realize: The parent class' realize handler.
* @parent_reset: The parent class' reset handler.
*
* An S/390 CPU model.
Expand All @@ -43,6 +44,7 @@ typedef struct S390CPUClass {
CPUClass parent_class;
/*< public >*/

DeviceRealize parent_realize;
void (*parent_reset)(CPUState *cpu);
} S390CPUClass;

Expand Down
16 changes: 14 additions & 2 deletions target-s390x/cpu.c
Expand Up @@ -97,6 +97,17 @@ static void s390_cpu_machine_reset_cb(void *opaque)
}
#endif

static void s390_cpu_realizefn(DeviceState *dev, Error **errp)
{
S390CPU *cpu = S390_CPU(dev);
S390CPUClass *scc = S390_CPU_GET_CLASS(dev);

qemu_init_vcpu(&cpu->env);
cpu_reset(CPU(cpu));

scc->parent_realize(dev, errp);
}

static void s390_cpu_initfn(Object *obj)
{
S390CPU *cpu = S390_CPU(obj);
Expand All @@ -122,8 +133,6 @@ static void s390_cpu_initfn(Object *obj)
#endif
env->cpu_num = cpu_num++;
env->ext_index = -1;

cpu_reset(CPU(cpu));
}

static void s390_cpu_finalize(Object *obj)
Expand All @@ -146,6 +155,9 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data)
CPUClass *cc = CPU_CLASS(scc);
DeviceClass *dc = DEVICE_CLASS(oc);

scc->parent_realize = dc->realize;
dc->realize = s390_cpu_realizefn;

scc->parent_reset = cc->reset;
cc->reset = s390_cpu_reset;

Expand Down
4 changes: 3 additions & 1 deletion target-s390x/helper.c
Expand Up @@ -85,7 +85,9 @@ S390CPU *cpu_s390x_init(const char *cpu_model)
}

env->cpu_model_str = cpu_model;
qemu_init_vcpu(env);

object_property_set_bool(OBJECT(cpu), true, "realized", NULL);

return cpu;
}

Expand Down

0 comments on commit b4e4147

Please sign in to comment.