Rollup not recalculated when order by field changes

[jondavis9898]

When the order by field on a child record has changed, if no other field involved in the rollup has changed, the rollup is not recalculated. The reason for this is that the order by field is not included in fieldsToSearchForChanges (https://github.com/afawcett/declarative-lookup-rollup-summaries/blob/master/rolluptool/src/classes/RollupService.cls#L540). Order by influences query based rollups and therefore not including it could result in the rolled up value being incorrect.

Note that this issue existed prior to PR #227.

See 3f2d31e#diff-4aa41bc6f886aeba1cba33ce3962348cR1535 for demonstration of issue. This test fails with prior code base on line 3f2d31e#diff-4aa41bc6f886aeba1cba33ce3962348cR1535 because the change to Amount__c is not considered material to rollup processing.

[afawcett]

Thanks @jondavis9898 another good spot, this will be most acute on the concatenation based aggregate rollups as you say.

[afawcett]

@jondavis9898 PR 244 fixes this i think, yes?

[jondavis9898]

Yep, this one is fixed in PR #244.

[afawcett]

Fixed in v1.24.