Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Handle a 429 Response? #136

Open
miketheman opened this issue May 31, 2023 · 0 comments
Open

Question: Handle a 429 Response? #136

miketheman opened this issue May 31, 2023 · 0 comments

Comments

@miketheman
Copy link

One of the implementations we're doing with this cool library is enabling username search.
The server-side API being called has rate limits applied, and may respond with a 429 Too Many Requests error, and today the library barfs:

Uncaught (in promise) Error: Server responded with status 429
    at extended.doFetch (autocomplete.js:224:1)
    at async extended.fetchResults (autocomplete.js:200:1)

(Thanks for adding that in #115 ! )

The question is:

  • should the library handle the response more gracefully?
  • should the server-side return an empty 200 response?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant