Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency on subprocess32 #64

Closed
ff2000 opened this issue Jul 25, 2013 · 2 comments
Closed

dependency on subprocess32 #64

ff2000 opened this issue Jul 25, 2013 · 2 comments

Comments

@ff2000
Copy link

ff2000 commented Jul 25, 2013

afew fails to run because it misses the package "subprocess32". As I understand [1] it's a port of the python-3.2 "subprocess" module to python 2.*. When I run with python3.2 this IMHO should not needed. Also the sources only import subprocess.
Could this requirement be made optional in setup.py? Or should that be simply patched out when installing for python3.2? I removed the subprocess32-line from "requires.txt" and at least it does not abort anymore with
pkg_resources.DistributionNotFound: subprocess32

[1] http://code.google.com/p/python-subprocess32/

@lucc
Copy link
Contributor

lucc commented Feb 9, 2017

It seems that subprocess32 is only mentioned in the setup.py and not in the code any longer. And if I can run it with python2 just fine even without installing subprocess32. So I assume that can be removed from setup.py.

@GuillaumeSeren
Copy link
Collaborator

GuillaumeSeren commented Feb 9, 2017

hey @ff2000, ass @lucc reported it seems not to used in the code,
so to me it is ok to remove it from the 'setup.py' file,
if later we want to use it we will consider to add it.

A PR will be welcome !

EricIO added a commit to EricIO/afew that referenced this issue Oct 10, 2017
The subprocess32 package is no longer used in code so can therefore be removed.

Per afewmail#64
@flokli flokli closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants