Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle DMARC report with empty spf or dkim XML nodes #305

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

aidecoe
Copy link
Contributor

@aidecoe aidecoe commented Feb 3, 2021

No description provided.

@aidecoe aidecoe changed the title Handle report with empty spf or dkim XML nodes Handle DMARC report with empty spf or dkim XML nodes Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #305 (41cf246) into master (c6a5b29) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   47.08%   46.99%   -0.09%     
==========================================
  Files          30       30              
  Lines        1079     1081       +2     
==========================================
  Hits          508      508              
- Misses        571      573       +2     
Flag Coverage Δ
unittests 46.99% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
afew/filters/DMARCReportInspectionFilter.py 24.28% <0.00%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a5b29...41cf246. Read the comment docs.

@GuillaumeSeren
Copy link
Collaborator

Hey @aidecoe ,
since this filter doesn't have a test yet how do you feel about adding one while working on this issue ?

@aidecoe
Copy link
Contributor Author

aidecoe commented Feb 6, 2021

Adding another one would be trivial for this case, but to start, it's quite an effort. I needed the quick fix to unblock processing of my mail and so I shared it here. If you don't mind keeping it open for a while, I'll add tests when I get a chance.

@GuillaumeSeren
Copy link
Collaborator

@aidecoe Yes I know it is an effort but if it can be done it would be so much better.

@GuillaumeSeren GuillaumeSeren merged commit e696759 into afewmail:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants