Fix segfault #44
Merged
Fix segfault #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`m_width` and `m_height` are of `int` type in the OpenEXR library. We currently keep the same types in our class but this may case issue when mapping 1D memory. In the most favorable case, they are multiplied together (Y framebuffer). For RGB(A) case, the required memory can also be 4 time larger. We check if resp. `m_width * m_height` and `4 * m_width * m_heigh` stay within the `int` higher limit. Thanks to @GAP-dev for bringing this issue. This commit also cleans a bit raw memory allocation in favor of `std::vector` container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the total memory required to store the whole image exceeds the upper int limit, in many places, there is memory violation #43.
This PR prevent this issue by performing an early check on the required memory size prior to allocation and access. Future revision shall handle such files by using larger types.