Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to reusable workflows #13

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Conversation

kaitj
Copy link
Contributor

@kaitj kaitj commented Aug 3, 2023

Proposed changes
Testing out using a centralized repository to call reusable workflows (https://github.com/khanlab/actions). My own tests seem to demonstrate this will work (but I didn't have a personal access token setup so those steps failed).

EDIT: Docs are failing due to changes that need to pushed to the docs/requirements.txt file - this has been done in #14 so I am going to leave it out of this one.

Types of changes
What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the maintenance Updates or improvements that do not change functionality of the code label Aug 3, 2023
@github-actions github-actions bot requested a review from tkkuehn August 3, 2023 15:05
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #13 (db1fba7) into main (ba3147d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          348       348           
=========================================
  Hits           348       348           
Components Coverage Δ
afids_utils/afids.py ∅ <ø> (∅)
afids_utils/ext 100.00% <ø> (ø)
afids_utils/transforms.py 100.00% <ø> (ø)

@kaitj kaitj changed the title Use reusable bump version workflow Update to reusable workflows Aug 4, 2023
@kaitj
Copy link
Contributor Author

kaitj commented Aug 24, 2023

Made the change to call the reusable workflows from the khanlab org rather than having to maintain a separate repo with the same workflows here in the afids org

@tkkuehn
Copy link
Contributor

tkkuehn commented Aug 29, 2023

Needs a merge from main, maybe that will fix the Readthedocs build failure?

@kaitj
Copy link
Contributor Author

kaitj commented Aug 29, 2023

That seemed to have fixed the checks, but it skipped building the docs here, which was the main doc causing the issue.

@kaitj kaitj merged commit d7c76c8 into afids:main Aug 29, 2023
6 checks passed
@kaitj kaitj deleted the maint/reusable-bump-wf branch August 29, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants