-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to reusable workflows #13
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 348 348
=========================================
Hits 348 348
|
Made the change to call the reusable workflows from the khanlab org rather than having to maintain a separate repo with the same workflows here in the afids org |
Needs a merge from main, maybe that will fix the Readthedocs build failure? |
That seemed to have fixed the checks, but it skipped building the docs here, which was the main doc causing the issue. |
Proposed changes
Testing out using a centralized repository to call reusable workflows (https://github.com/khanlab/actions). My own tests seem to demonstrate this will work (but I didn't have a personal access token setup so those steps failed).
EDIT: Docs are failing due to changes that need to pushed to the docs/requirements.txt file - this has been done in #14 so I am going to leave it out of this one.
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!poe quality
taskNotes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.