-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert between LPS/RAS coordinate systems #32
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 503 529 +26
=========================================
+ Hits 503 529 +26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, just a few nitpicky style comments
- make use of attrs.evolve to create new instances with modifications - use zipped list for interating and comparing new vs old afids - return same instance of intended coordinate system is the same as original
Implemented the suggested changes and also took the opportunity to update the docs (minor update includes adding |
Proposed changes
Adds a method that takes in one AfidSet in either "LPS" or "RAS" coordinate system and returns a new AfidSet in the opposite coordinate system. Open to moving this as a method of AfidSet, but opted for a separate function as a first pass.
One thing that needs to be checked is if the coordinates need to be in a certain system to work with the affine pulled via nibabel in the world / voxel functions, but that should be done in a separate PR if an update is needed.
Types of changes
What types of changes does your code introduce? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!poe quality
taskNotes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.