Add transformation (world-to-voxel) #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 6 +3
Lines 83 133 +50
=========================================
+ Hits 83 133 +50
|
- added hypothesis['numpy'] to create numpy arrays for strategies - add world2voxel function - add error checks for invalid combinations - add test cases - simplified padding (from original) to apply to just a single voxel
kaitj
force-pushed
the
enh/transforms
branch
2 times, most recently
from
fac0999
to
f5f2465
Compare
tkkuehn
requested changes
Jun 22, 2023
kaitj
force-pushed
the
enh/transforms
branch
2 times, most recently
from
55ede7d
to
eb765a5
Compare
tkkuehn
requested changes
Jun 23, 2023
kaitj
force-pushed
the
enh/transforms
branch
2 times, most recently
from
91088c8
to
b4c6070
Compare
- generate values to draw from and compose affine transform with for scaling, rotation and translation components - permutate though scaling, rotation, and translation matrices to give more variance in the affine - also add transforms as a component to codecov - quality fixes - rename codecov components to reflect paths
tkkuehn
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Probably the last "small" PR, adding in the transformation from world to voxel coordinates. The affine matrix had to separately constructed by the values generated (to create a valid matrix).
Note: I updated the
codecovcomponent names to reflect the paths of the files / modules, should be updated in the next PR if it does not show up in this one.Types of changes
What types of changes does your code introduce? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!poe qualitytaskNotes
All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.