Fixed empty returns (boa-dev#251) (boa-dev#257)

afinch7 · Mar 6, 2020 · f628f4c · f628f4c
1 parent 86052d6
commit f628f4c
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 1 deletion.
diff --git a/boa/src/syntax/parser/mod.rs b/boa/src/syntax/parser/mod.rs
@@ -222,7 +222,13 @@ impl Parser {
 
                 Ok(Expr::new(ExprDef::ConstDecl(vars)))
             }
-            Keyword::Return => Ok(Expr::new(ExprDef::Return(Some(Box::new(self.parse()?))))),
+            Keyword::Return => match self.get_token(self.pos)?.data {
+                TokenData::Punctuator(Punctuator::Semicolon)
+                | TokenData::Punctuator(Punctuator::CloseBlock) => {
+                    Ok(Expr::new(ExprDef::Return(None)))
+                }
+                _ => Ok(Expr::new(ExprDef::Return(Some(Box::new(self.parse()?))))),
+            },
             Keyword::New => {
                 let call = self.parse()?;
                 match call.def {

diff --git a/boa/src/syntax/parser/tests.rs b/boa/src/syntax/parser/tests.rs
@@ -631,6 +631,28 @@ fn check_function_declarations() {
         ))],
     );
 
+    check_parser(
+        "function foo(a) { return; }",
+        &[Expr::new(ExprDef::FunctionDecl(
+            Some(String::from("foo")),
+            vec![Expr::new(ExprDef::Local(String::from("a")))],
+            Box::new(Expr::new(ExprDef::Block(vec![Expr::new(ExprDef::Return(
+                None,
+            ))]))),
+        ))],
+    );
+
+    check_parser(
+        "function foo(a) { return }",
+        &[Expr::new(ExprDef::FunctionDecl(
+            Some(String::from("foo")),
+            vec![Expr::new(ExprDef::Local(String::from("a")))],
+            Box::new(Expr::new(ExprDef::Block(vec![Expr::new(ExprDef::Return(
+                None,
+            ))]))),
+        ))],
+    );
+
     check_parser(
         "function (a, ...b) {}",
         &[Expr::new(ExprDef::FunctionDecl(
@@ -688,4 +710,30 @@ fn check_function_declarations() {
             ))]))),
         ))],
     );
+
+    check_parser(
+        "(a, b) => { return; }",
+        &[Expr::new(ExprDef::ArrowFunctionDecl(
+            vec![
+                Expr::new(ExprDef::Local(String::from("a"))),
+                Expr::new(ExprDef::Local(String::from("b"))),
+            ],
+            Box::new(Expr::new(ExprDef::Block(vec![Expr::new(ExprDef::Return(
+                None,
+            ))]))),
+        ))],
+    );
+
+    check_parser(
+        "(a, b) => { return }",
+        &[Expr::new(ExprDef::ArrowFunctionDecl(
+            vec![
+                Expr::new(ExprDef::Local(String::from("a"))),
+                Expr::new(ExprDef::Local(String::from("b"))),
+            ],
+            Box::new(Expr::new(ExprDef::Block(vec![Expr::new(ExprDef::Return(
+                None,
+            ))]))),
+        ))],
+    );
 }