refactor: Use Write trait, separate term info #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afnanenayet
force-pushed
the
afnan/generic-writer
branch
2 times, most recently
from
b7e194a
to
4e4fe20
Compare
afnanenayet
force-pushed
the
afnan/generic-writer
branch
3 times, most recently
from
ac8b727
to
2b30c96
Compare
Pass a generic write trait to the render trait so we can seamlessly swap out different sinks to write out to. We also pass in the term object separately as an optional reference so renderers can dynamically react to the terminal/presence of a TTY.
afnanenayet
force-pushed
the
afnan/generic-writer
branch
from
2b30c96
to
d5c557f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass a generic write trait to the render trait so we can seamlessly swap
out different sinks to write out to. We also pass in the term object
separately as an optional reference so renderers can dynamically react
to the terminal/presence of a TTY.