Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Make build_example lane optional #7

Closed
yoiang opened this issue Dec 14, 2015 · 6 comments
Closed

Make build_example lane optional #7

yoiang opened this issue Dec 14, 2015 · 6 comments

Comments

@yoiang
Copy link

yoiang commented Dec 14, 2015

Hey y'all! The fastlane scripts you've put together look awesome!

For projects with no Example it would be great to the ability to choose not to attempt to build an Example project, currently not specifying one causes the scripts to fail.

Lemme know if this is in line with the project, if so I can try and make a PR!

@kcharwood
Copy link
Contributor

Thanks @yoiang.

In that case, just use the test_framework lane directly. ci_commit was designed to roll both testing and building examples into one, but test_framework works fine for projects without an example. I'm doing there here for AFOAuth2Manager.

Would love your feedback. I'm still working out the kinks here!

@yoiang
Copy link
Author

yoiang commented Dec 15, 2015

@kcharwood That worked great, thank you!

Only issue I had after that was Travis skipped the deploy task because it didn't think it was a tagged commit (using fastlane prepare_framework_release version:0.5.6 --env deploy). I'll look into it more tomorrow and see if I can't suss it out but I noticed you had deploy disabled in AFOAuth2Manager, is it currently not functioning?

@kcharwood
Copy link
Contributor

I'm still working on the deploy step for Travis. I haven't quite gotten it to work right for me with AFNetworking, and I haven't had time to circle back on it. I've been doing the complete_framework_release step manually from my own machine.

@yoiang
Copy link
Author

yoiang commented Dec 15, 2015

Gotcha! Anyway I can help?

@kcharwood
Copy link
Contributor

The thing I'm struggling with right now is how do I setup a build matrix (concurrent jobs that run different iOS versions/xcodes/etc), and if all the jobs pass, how do I then run the deploy step. I haven't been able to thread that needle yet with Travis.

@kcharwood
Copy link
Contributor

I've got a email going on with Travis. It looks like this isn't possible if you are using build matrices, but it sounds like they are working on something that may help me out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants