Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use default discord_client_id #73

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

afonsojramos
Copy link
Owner

πŸ“‘ Description

Partially closes #46. Changes related to Trakt might also be brought into this PR if changes are not too drastic.

βœ… Checks

  • code: My pull request adheres to the code style of this project
  • docs: Added / updated
  • tests: All the tests have passed

β„Ή Additional Information

Please take a look if it makes sense @sitiom @rollingmoai

Copy link
Contributor

@sitiom sitiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes related to Trakt might also be brought into this PR if changes are not too drastic.

It would be nice to hardcode the TMDB API key as well (Example: https://github.com/xbmc/xbmc/blob/495a07ad6805ffc17475d6b7181a92ce16d1c01e/addons/metadata.themoviedb.org.python/python/lib/tmdbscraper/tmdbapi.py#L36)

@afonsojramos
Copy link
Owner Author

@sitiom Interesting πŸ€” But that seems to open these API keys to be used outside of their intended use....

@afonsojramos
Copy link
Owner Author

@sitiom Further investigation proved that it is indeed not prudent that I ship these API keys with the binary as that would be a break of the ToS with TMDB.

@afonsojramos afonsojramos merged commit 5f0f03e into main Mar 11, 2024
9 checks passed
@afonsojramos afonsojramos deleted the chore/fix-discord-client-id branch March 11, 2024 11:37
@sitiom
Copy link
Contributor

sitiom commented Mar 11, 2024

Where is it specified? And how come the TMDB scraper addon above from Kodi not break TOS?

@afonsojramos
Copy link
Owner Author

Best I've found was this tbh: https://www.themoviedb.org/talk/6272acd4a313b812cd7aab5e

But with so many out there... Why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Built-in client IDs / API keys for Trakt, Discord, and TMDB
2 participants