getHTTPMessage

afontainec · May 29, 2020 · a39a786 · a39a786
1 parent 6604b57
commit a39a786
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/models/ErrorHandler.js b/models/ErrorHandler.js
@@ -62,9 +62,8 @@ class ErrorHandler {
 
   getHTTPMessage(error) {
     error = error || {};
-    const translation = this.ERROR_TRANSLATE[error.chinchayCode];
-    if (!translation) return 'Internal Error';
-    return translation.message;
+    const translation = this.ERROR_TRANSLATE[error.chinchayCode] || {};
+    return translation.message || error.chinchayMessage || 'Internal Error';
   }
 
   getHTTPCodeAndMessage(error) {

diff --git a/test/models/ErrorHandler/getHTTPMessage.js b/test/models/ErrorHandler/getHTTPMessage.js
@@ -26,6 +26,14 @@ describe('Error Handler intialize', () => {
     assert.equal(message, expected);
   });
 
+  it('code is not in translate but has chinchayMessage', async () => {
+    const error = { chinchayCode: 427031, chinchayMessage: 'this is the error' };
+    const handler = new ErrorHandler();
+    const message = handler.getHTTPMessage(error);
+    const expected = 'this is the error';
+    assert.equal(message, expected);
+  });
+
   it('error is undefined', async () => {
     const handler = new ErrorHandler();
     const message = handler.getHTTPMessage();