Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive / relative dimensions #9

Open
strarsis opened this issue Jan 10, 2020 · 3 comments
Open

Responsive / relative dimensions #9

strarsis opened this issue Jan 10, 2020 · 3 comments

Comments

@strarsis
Copy link

It would be great if the PDF viewer could just occupy 100% width and height proportional to e.g. DIN A4 or Letter format or some other ratio. The PDFjs viewer will automatically show the whole page on mobile (thumbnail mode), this should also become possible by this.

@afragen
Copy link
Owner

afragen commented Jan 10, 2020

This plugin doesn't use anything to create a PDF or display a PDF, except for an object tag or an iframe, depending on mobile or not.

You can set the height and width in the block setting.

@afragen afragen closed this as completed Jan 10, 2020
@strarsis
Copy link
Author

@afragen: But I can only set the width and height in pixel (px), not in another unit like % or vw.

@afragen
Copy link
Owner

afragen commented Jan 10, 2020

That's because I hardcoded the px value. I understand that this is limiting but I didn't have a simple way to ensure the unit was passed.

I'm happy to review a PR if you can create a solution.

@afragen afragen reopened this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants