Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate more seamlessly with core plugin and theme installation #884

Closed
westonruter opened this issue May 24, 2020 · 2 comments
Closed

Comments

@westonruter
Copy link

When the GitHub Update plugin is installed, it adds its UI under the Settings menu. This was
unexpected for me. I was expecting there to be a way to install a plugin from the plugins screen when clicking the Upload Plugin button:

image

It would be great if the GitHub Updater plugin installation form were included here somehow:

image

This would make it much more discoverable for how to install plugins from GitHub, as right now I feel the GitHub Updater UI is somewhat buried.

The same applies to the theme installation flow.

@westonruter westonruter changed the title Integrate more seamlessly with core plugin installation Integrate more seamlessly with core plugin and theme installation May 24, 2020
@afragen
Copy link
Owner

afragen commented May 24, 2020

Everything in GHU is quite modularity designed. All the tabs and sub tabs of the Settings can be installed relatively independently of all the others. This is one of the reasons that adding Gist support was relatively easy.

I’m not a big fan of inserting my plugin behaviors directly into core locations and I imagine it would take more effort and add to the complexity. It makes support simpler as in only need to point to one location.

I haven’t yet added WP-CLI support for Gist installations but you can certainly use it for everything else.

@afragen
Copy link
Owner

afragen commented May 24, 2020

Also, the core upload plugin/theme is fundamentally different that installing form a remote location.

@afragen afragen closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants