New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest aframe master #163
Use latest aframe master #163
Conversation
Cool! I'll give it a try later when I'll arrive home. Could you squash the commits? Thanks! |
yesterday @dmarcos said github does that for you, ran into rebase/squash issues yesterday doing touch support for 0.4.0... but I think squash only will probably be ok. |
aceed01
to
5c5fe58
Compare
(@fernandojsg squashed for you.) |
@machenmusik I've just tried this PR and the controllers doesn't move, which aframe.min.js are you using? the current 0.4.0 dist? |
it occurs to me that although I split the original Touch support into 3, I didn't test that this worked independently. Now that we have the official 0.4.0 build, let me quickly check and redo. May need to merge this back together with the Oculus Touch support PR... |
running into merge issues now. if you already updated master to 0.4.0, you may only need 3967487 |
original A-Painter was vive only so this patch sets to "OpenVR Gamepad"
3967487
to
1db517a
Compare
ok redone and tested on Vive |
@machenmusik cool! it's working, thanks for the work here 👍 |
per discussion on #159