New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/attribute/component/ #192

Merged

fernandojsg merged 1 commit into aframevr:master from ngokevin:component

Jul 11, 2016

Member

ngokevin commented Jul 11, 2016 •

edited

Loading

General s/attribute/component/ for the Components Panel.
Move AddComponent to separate file.
Combine AttributesPanel + Attributes to ComponentsContainer
Rename MixinsComponent to just Mixins
Rename AttributeRow to PropertyRow
Rename AttributesSidebar to just Sidebar

Final structure:

Sidebar
- ComponentsContainer
  - CommonComponents
    - Mixins
  - AddComponent
  - Component
    - PropertyRow

ngokevin added needs review code-quality labels

fernandojsg added needs rebase and removed needs review labels

Member

fernandojsg commented Jul 11, 2016

👍


          s/attribute/component/

4737bf5

ngokevin force-pushed the component branch from 6ed2bc8 to 4737bf5 Compare

July 11, 2016 23:02

ngokevin added needs review and removed needs rebase labels

Member Author

ngokevin commented Jul 11, 2016

Rebased.

fernandojsg merged commit 965e268 into aframevr:master

Member Author

ngokevin commented Jul 11, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment