Set renderer.useLegacyLights instead of renderer.physicallyCorrectLights

aframevr · Jun 5, 2023 · 4a8da9d · 4a8da9d
1 parent 96b6f46
commit 4a8da9d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/systems/renderer.js b/src/systems/renderer.js
@@ -32,7 +32,7 @@ module.exports.System = registerSystem('renderer', {
     // This is the rendering engine, such as THREE.js so copy over any persistent properties from the rendering system.
     var renderer = sceneEl.renderer;
     renderer.sortObjects = data.sortObjects;
-    renderer.physicallyCorrectLights = data.physicallyCorrectLights;
+    renderer.useLegacyLights = !data.physicallyCorrectLights;
     renderer.toneMapping = THREE[toneMappingName + 'ToneMapping'];
 
     THREE.ColorManagement.enabled = data.colorManagement;

diff --git a/tests/systems/renderer.test.js b/tests/systems/renderer.test.js
@@ -22,7 +22,7 @@ suite('renderer', function () {
       var renderingEngine = sceneEl.renderer;
       assert.strictEqual(renderingEngine.outputColorSpace, THREE.SRGBColorSpace);
       assert.notOk(renderingEngine.sortObjects);
-      assert.strictEqual(renderingEngine.physicallyCorrectLights, false);
+      assert.strictEqual(renderingEngine.useLegacyLights, true);
       done();
     });
     document.body.appendChild(sceneEl);
@@ -53,7 +53,7 @@ suite('renderer', function () {
     var sceneEl = createScene();
     sceneEl.setAttribute('renderer', 'physicallyCorrectLights: true;');
     sceneEl.addEventListener('loaded', function () {
-      assert.ok(sceneEl.renderer.physicallyCorrectLights);
+      assert.notOk(sceneEl.renderer.useLegacyLights);
       done();
     });
     document.body.appendChild(sceneEl);