Remove attribute from DOM when removing component (through mixin remo…

…val/update) (#5492) Co-authored-by: Noeri Huisman <mrxz@users.noreply.github.com>
aframevr · Mar 7, 2024 · 555bd47 · 555bd47
1 parent 53bc87f
commit 555bd47
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/core/a-entity.js b/src/core/a-entity.js
@@ -379,6 +379,10 @@ class AEntity extends ANode {
     if (destroy) {
       component.destroy();
       delete this.components[name];
+      // Remove attribute from DOM, if still present
+      if (this.hasAttribute(name)) {
+        window.HTMLElement.prototype.removeAttribute.call(this, name);
+      }
     }
 
     this.emit('componentremoved', component.evtDetail, false);

diff --git a/tests/core/a-mixin.test.js b/tests/core/a-mixin.test.js
@@ -97,7 +97,7 @@ suite('a-mixin', function () {
       testEl.setAttribute('delete-mixin', '');
       testEl.addEventListener('loaded', function () {
         assert.equal(testEl.getAttribute('mixin'), null);
-        assert.equal(testEl.getAttribute('material'), '');
+        assert.equal(testEl.getAttribute('material'), null);
         done();
       });
       el.sceneEl.appendChild(testEl);