Properly dispose renderer to stop the animation loop when removing th…

…e scene from the DOM (#5112)
aframevr · Sep 10, 2022 · fb67365 · fb67365
1 parent 34665ed
commit fb67365
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/src/core/scene/a-scene.js b/src/core/scene/a-scene.js
@@ -214,7 +214,7 @@ module.exports.AScene = registerElement('a-scene', {
         window.removeEventListener('vrdisplaypointerrestricted', this.pointerRestrictedBound);
         window.removeEventListener('vrdisplaypointerunrestricted', this.pointerUnrestrictedBound);
         window.removeEventListener('sessionend', this.resize);
-        this.renderer.xr.dispose();
+        this.renderer.dispose();
       }
     },
 

diff --git a/tests/__init.test.js b/tests/__init.test.js
@@ -41,6 +41,7 @@ setup(function () {
       dispose: function () {},
       enabled: false
     },
+    dispose: function () {},
     getContext: function () { return undefined; },
     setAnimationLoop: function () {},
     setSize: function () {},

diff --git a/tests/core/scene/a-scene.test.js b/tests/core/scene/a-scene.test.js
@@ -146,6 +146,7 @@ suite('a-scene (without renderer)', function () {
           setPoseTarget: function () {},
           dispose: function () {}
         },
+        dispose: function () {},
         getContext: function () { return undefined; },
         setAnimationLoop: function () {},
         setPixelRatio: function () {},
@@ -271,6 +272,7 @@ suite('a-scene (without renderer)', function () {
           setPoseTarget: function () {},
           dispose: function () {}
         },
+        dispose: function () {},
         setAnimationLoop: function () {},
         setPixelRatio: function () {},
         setSize: function () {},
@@ -445,6 +447,7 @@ suite('a-scene (without renderer)', function () {
           setDevice: function () {},
           dispose: function () {}
         },
+        dispose: function () {},
         setAnimationLoop: function () {},
         setSize: setSizeSpy,
         render: function () {}