Spot light position bug #1624
Comments
FrederickDesimpel
changed the title
|
not sure if it is the spotlight itself that is in the wrong place or the editor's cone visualisation. |
|
Is this related to #1621? |
|
no this is just about the position of the object |
|
@FrederickDesimpel can I have the example scene that you're using in your screenshot to test it on the editor? |
|
@fernandojsg i don't seem to have it around anymore... should be easy to recreate, it was just a spotlight and a sphere to check it's position... can't seem to get into the editor anymore for the moment, so i can't recreate it now. |
|
@fernandojsg i have a scene that clearly shows the problem: http://www.frederickdesimpel.be/test/webVR/Aframe/test11-spot-showbug-spotPos.html the yellow line is from the light aframe element position, the white line is from the position of the light itself attached to the elements object3D. it is exactly one unit too high. |
|
Made a temporary fix here. The functionality to the end user should be as expected. The real cause can be hunted upon later... |
Fixed a bug with spotlight angle only being set with degtoRad when light is created, further updates were set in radians. Made the getlight function a method inside the component, so i could set this.defaultTarget. Moved the spotlight specific setup of that defaultTarget inside the setlight method. It is added to the light elements object3D group to enable spotlight orientation. Added a temporary fix for issue aframevr#1624, otherwise i couldn't get spotlight orientation correct. there's a suite of unit test for light target, as wel as for both bugfixes.
…a bug with spotlight position. (#1728) * squash of 11 commits Fixed a bug with spotlight angle only being set with degtoRad when light is created, further updates were set in radians. Made the getlight function a method inside the component, so i could set this.defaultTarget. Moved the spotlight specific setup of that defaultTarget inside the setlight method. It is added to the light elements object3D group to enable spotlight orientation. Added a temporary fix for issue #1624, otherwise i couldn't get spotlight orientation correct. there's a suite of unit test for light target, as wel as for both bugfixes. * updated unit test light suite * Docs: added target property to spotlight component and entity sections
|
fixed |
the cone of a spot light seems to be a unit higher then it's origin :
http://www.frederickdesimpel.be/test/webVR/Aframe/spot-bug.jpg
The text was updated successfully, but these errors were encountered: