Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vr-hemispherelight needs to support attributeChangedCallback #22

Closed
cvan opened this issue Sep 22, 2015 · 3 comments
Closed

vr-hemispherelight needs to support attributeChangedCallback #22

cvan opened this issue Sep 22, 2015 · 3 comments

Comments

@cvan
Copy link
Contributor

cvan commented Sep 22, 2015

In the vr-hemispherelight component, there's only a createdCallback, not a attributeChangedCallback.
@ngokevin
Copy link
Member

I am creating a vr-light component that will have attributeChangedCallback, and then we can remove vr-hemispherelight

<vr-light type="hemisphere">

@cvan
Copy link
Contributor Author

cvan commented Sep 22, 2015

nice!

@cvan
Copy link
Contributor Author

cvan commented Oct 19, 2015

it's gone

@cvan cvan closed this as completed Oct 19, 2015
ngokevin pushed a commit to ngokevin/aframe that referenced this issue Jan 8, 2016
@caseyyee
returns user to mono-mode after exiting VR, fixes aframevr#22
7267186
ngokevin pushed a commit to ngokevin/aframe that referenced this issue Jan 8, 2016
@dmarcos
Merge pull request aframevr#24 from caseyyee/revertmono
40f64c4 
returns user to mono-mode after exiting VR, fixes aframevr#22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cvan @ngokevin