Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a-sky broken in 0.8.0 #3428

Closed
crcdng opened this issue Mar 9, 2018 · 9 comments
Closed

a-sky broken in 0.8.0 #3428

crcdng opened this issue Mar 9, 2018 · 9 comments

Comments

@crcdng
Copy link

crcdng commented Mar 9, 2018

Description:

  • A-Frame Version:
    0.8.0

  • Platform / Device:

Chrome and Firefox / mac

  • Reproducible Code Snippet or URL:
<a-scene>
       <a-sky color="#030303"></a-sky>
</a-scene>

Sky is not rendered, white page instead. Works in 0.7.1

Console Warrnigs:

THREE.WebGLRenderer: .shadowMap.renderReverseSided has been removed. Set Material.shadowSide instead.
aframe-v0.8.0.js:50683:5
THREE.WebGLRenderer: .shadowMap.renderSingleSided has been removed. Set Material.shadowSide instead.
@stephanedemotte
Copy link

quick fix sky.object3DMap.mesh.material.side = THREE.BackSide

@SteveX
Copy link
Contributor

SteveX commented Mar 10, 2018

Same for my scenes as well.
Where would I apply that quick fix? Or is this something I should wait for in the next version?

@dmarcos
Copy link
Member

dmarcos commented Mar 10, 2018

Two work arounds:

  1. If you are applying a color to the background use the background component on a-scene: https://aframe.io/docs/0.8.0/components/background.html#sidebar

  2. You can build your own entity instead of using the a-sky primitive:

<a-entity material="src: #yourImage; side: back; shader: flat" 
                geometry="primitive: sphere; radius: 5000; segmentsWidth: 64; segmentsHeight: 32">
</a-entity>

@crcdng
Copy link
Author

crcdng commented Mar 11, 2018

Why is this issue closed? Do you intend to fix the bug?

@dmarcos
Copy link
Member

dmarcos commented Mar 11, 2018

@i3games The bug is fixed now on master and it will ship in the next A-Frame version. You can use the workarounds described above or use the master branch in your application (https://rawgit.com/aframevr/aframe/master/dist/aframe-master.min.js)

@crcdng
Copy link
Author

crcdng commented Mar 11, 2018

Ok, cool.

@SteveX
Copy link
Contributor

SteveX commented Mar 11, 2018

Thanks!

@ngokevin
Copy link
Member

I've hot-patched the fix into 0.8.0. So check it now!

@crcdng
Copy link
Author

crcdng commented Mar 11, 2018

<a-sky> is back :) Thanks.

jsantell pushed a commit to jsantell/aframe that referenced this issue Mar 15, 2018
…3429) (aframevr#3250)

* remove object allocations from cursor component

* only emit raycaster intersection/intersected events if newly intersected

* fix disabling of raycaster.showLine

* fix disabling raycaster.line getting overridden by tick line updater

* remove arrow fn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants