Pass the target element to the events emitted by the cursor (fixes #1… #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As requested by @mayognaise. Is this what you need? |
|
looks good. initial raycaster tests would be great |
|
Hi! Is it possible to put this into |
|
@ngokevin Can we cherry pick this commit and make a 0.1.3 release? |
|
@mayognaise I can provide you a custom build of 0.1.2 with this cherry-picked. We might be able to release next week, and we might clear the blockers preventing you to upgrade as well. |
dmarcos
force-pushed
the
clickTarget
branch
3 times, most recently
from
f87a0da
to
5f7ec4f
Compare
| var entityFactory = require('../helpers').entityFactory; | ||
|
|
||
| suite('raycaster', function () { | ||
| 'use strict'; |
There was a problem hiding this comment.
don't think we need the strict since we have a linter
|
r+wc we'll do stronger tests later when we improve the raycaster component |
|
Notice that the raycaster test is a bonus. This patch doesn't touch the raycaster but the cursor |
|
looks good |
|
Thanks for the bonus. |
dmarcos
added a commit
that referenced
this pull request
Mar 5, 2016
Pass the target element to the events emitted by the cursor (fixes #1…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…067)