fix page-reloads on iOS (#2782) #2925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tried on Android? |
|
No, but the touched lines belong to the |
|
Or I'm missing something, in that case: enlighten me :-) |
|
Thanks! 🥇 |
cvan
reviewed
Sep 5, 2017
| @@ -47,9 +47,9 @@ function iOSWakeLock() { | |||
| this.request = function() { | |||
| if (!timer) { | |||
| timer = setInterval(function() { | |||
| window.location = window.location; | |||
| window.location.href = '/'; | |||
There was a problem hiding this comment.
how does this fix? this assumes a page lives at the root, right?
a better wakelock imo would be to play an empty autoplay audio track on loop (but would have to test to guarantee no perf impact).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
On iOS devices, the application seems to randomly reload. This has been pinpointed to a reload after 30 seconds of inactivity while in VR mode, caused by the iOS wakelock feature. As seen in other wakelock-implementations and issues, the
window.location = window.locationcreates this issue.Changes proposed:
Update the wakelock implementation to match other implementation which don't cause this reload-bug.
One thing to mention is the wakelock does not work on iOS (11), however I think it's better to have an application which will sleep after X seconds, instead of an application which will reload every X seconds.