Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sources in video (fix #3173) #3176

Merged
merged 8 commits into from Oct 19, 2017
Merged

Support sources in video (fix #3173) #3176

merged 8 commits into from Oct 19, 2017

Commits on Oct 18, 2017

  1. modify video to use source element instead of src attribute

    @machenmusik
    machenmusik committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    4013b78 View commit details
    Browse the repository at this point in the history

  2. add test for video with source element instead of src attribute

    @machenmusik
    machenmusik committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    976aafa View commit details
    Browse the repository at this point in the history

  3. modify to use anonymous video with source element instead of with id … 

    …and src attributes
    @machenmusik
    machenmusik committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    b320c2d View commit details
    Browse the repository at this point in the history

  4. support video with source element(s) rather than src attribute

    @machenmusik
    machenmusik committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    9f8ae0c View commit details
    Browse the repository at this point in the history

  5. fix pre-existing preload usage per discussion on PR

    @machenmusik
    machenmusik committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    23f95bc View commit details
    Browse the repository at this point in the history

  6. editorial changes per discussion on PR

    @machenmusik
    machenmusik committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    00b2929 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2017

  1. add warning when audio/video asset has neither src nor srcObject

    @machenmusik
    machenmusik committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    8e3a160 View commit details
    Browse the repository at this point in the history

  2. remove querySelector per discussion on PR; use childElementCount as a… 

    … weak check for child source elements
    @machenmusik
    machenmusik committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    c303a8e View commit details
    Browse the repository at this point in the history