Remove trackpaddown event from the downEvents to not monopolize all buttons on GearVR and Oculus Go #3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uttons on GearVR and Oculus Go and make it consistent with other controllers
dmarcos
force-pushed
the
removeTrackpaddown
branch
from
3ea4dca
to
6560480
Compare
|
The intent here is: if controller has trigger, use that, else use trackpad (e.g. on daydream) correct? |
|
correct. We map click to trigger button on all controllers except daydream that does not have one. This PR makes it more consistent and frees the trackpad for other input on Oculus Go and Gear VR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.