Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix component.events singleton, events being overridden by components of the same type #4250

Merged
merged 1 commit into from Aug 7, 2019

Conversation

ngokevin
Copy link
Member

@ngokevin ngokevin commented Aug 7, 2019

Description:

Two component instances of same type using events API would interfere with each other.

Changes proposed:

  • Don't overwrite the events prototype with a binded version.

@dmarcos dmarcos merged commit 40b4465 into aframevr:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants