Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pico4 controllers support #5281

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

dmarcos
Copy link
Member

@dmarcos dmarcos commented May 2, 2023

To test:

@felixtrz If you have some bandwidth it would be really cool if you test this out. I don't have access to a Pico4 device. Thanks so much!

@felixtrz
Copy link
Contributor

felixtrz commented May 2, 2023

Hey @dmarcos , I tested it out on Pico 4, the controller models show up as expected, the material on the controller meshes looks unrealistically shiny, and the controllers are not animated (nothing happens when trigger is pressed or thumbstick is pushed, etc.) The placement of the controllers seems good.

screenrecording-20230502-234452_RwAzlP8E.mp4

@dmarcos
Copy link
Member Author

dmarcos commented May 2, 2023

Thanks so much! You rock. Correct model placement and button events working is already good progress.

Lack of buttons animation expected. Not implemented yet.

About materials. Just using the model from the webxr-input-profiles repo. Perhaps lighting of this particular scene interacting with the material

@dmarcos
Copy link
Member Author

dmarcos commented May 4, 2023

I opened a separate issue to track the button animation #5286

@dmarcos dmarcos merged commit d980c31 into aframevr:master May 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants