New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set renderer.useLegacyLights instead of renderer.physicallyCorrectLights #5297

Merged

dmarcos merged 1 commit into aframevr:master from mrxz:use-legacy-lights

Jun 14, 2023

Contributor

mrxz commented Jun 5, 2023

Description:
Fixes #5293

Changes proposed:

Set renderer.useLegacyLights instead of the deprecated renderer.physicallyCorrectLights


          Set renderer.useLegacyLights instead of renderer.physicallyCorrectLights

4a8da9d

Member

dmarcos commented Jun 14, 2023

Thanks so much!

dmarcos merged commit 4352692 into aframevr:master

1 check passed

vincentfretin mentioned this pull request

Set useLegacyLights only if necessary to remove warning about deprecated api #5389

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment