-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Chrolopleth map to the Heat Map dialog #7143
Added Chrolopleth map to the Heat Map dialog #7143
Conversation
@N-thony Please could you review? thanks |
Thankyou @N-thony , I've made some of the changes you requested, kindly review. Thanks |
@EstherNjeriLiberatta, we can have a quick call on this when you have time. |
@N-thony thank you for your help so far on this dialogue. |
@HawardKetoyoMsatsi happy to take over? |
@shadrackkibet yes I will fix this. |
@HawardKetoyoMsatsi Thank you for helping out on this, I'll work with you to know how you fix the problem I was having. |
@EstherNjeriLiberatta I have managed to fix this error in R. Since you had already written the vb code once you have time we can add the R-code I wrote into your vb code together. |
Thank you, @HawardKetoyoMsatsi Getting to you on skype. |
@EstherNjeriLiberatta How far with this task, Have you been able to add the R code I gave you in R-Instat. |
Hello @lilyclements when running the code below I get the following error. What could the problem be in the code?
|
@EstherNjeriLiberatta the error says "object 'long' not found". You use "long" in the |
@lilyclements here is the R output |
Great, so you want to call |
Okay, thank you so much |
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
f457d9e
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
@N-thony @africanmathsinitiative/developers This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EstherNjeriLiberatta Thank you for the changes.
Please could you also look at the 2 unresolved comments from 10 July (see unresolved comments above)
Thanks
@lloyddewit I hope I have resolved all the requested changes from you and @N-thony, thank you so much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EstherNjeriLiberatta This is looking really good, you've made some good quality improvements since the first commits.
I think we're very nearly ready to merge, just a couple of final questions.
Thank you for your patience
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
@lloyddewit Thank you, I have made the changes. |
@rdstern There are significant changes since your last approval. If you can test/approve again, then we can merge, thanks |
Fixes #6782
In this PR I have made a few adjustments to the heatmap dialogue and added a choropleth map option as another button.
To test the choropleth map use the data set below.
mydata.csv
@rdstern @africanmathsinitiative/developers This is ready for review.