Updated Boxplot dialogue's Plot Options to the new system. #7570
Conversation
EstherNjeriLiberatta
changed the title
There was a problem hiding this comment.
@N-thony this is great. I have 2 small cosmetic points - but please only if you agree. I am not so good on these aspects.
I wonder if the width of the Options button should be the same as the width of the selector? And aligned with it.
Could there be a horizontal line below the first entry?#
What do you think. This would apply to each of them.
It does make the dialogue look simpler, which is a good thing.
@rdstern I agrre with you, @EstherNjeriLiberatta please, can you make these changes? |
@rdstern Thanks for reviewing, I have made the width of the Options button similar to that of the selector. However, I didn't understand the horizontal line you talked about. Do you have an example dialogue I can look up? |
|
@EstherNjeriLiberatta please check the horizontal line for yourself, as it may not be needed. One example is Model > Fit Model > One Variable - the Test button and the button that says Binomial. But looking at that, I am not sure whether a line is needed, given there are far fewer entries. |
|
@rdstern Thank you I have checked it, and I agree with you. The dialogue is ready for review. |
There was a problem hiding this comment.
@EstherNjeriLiberatta it is doing more than I thought - but also therefore sometimes less!
When I am on boxplot, then I can get the ordinary plot options and boxplot options. I can press violin, but I still get the boxplot options. If I check tufte, then I get tufteboxplots.
I was thinking that I might get what I press, even though it isn't sensible. I am happy that I can't, but is it possible to disable the ones that I can't get?
If I am on boxplot (or tufte), or violin, then I can check the points and this adds the jitter layer. But I can't get it. I should be able to.
|
@rdstern I have disabled the options that are not needed when you click on either button box/Tufte, jitter, or violin. It's possible to get the jitter layer when you check the |
There was a problem hiding this comment.
@EstherNjeriLiberatta that has been ambitious, to just have those enabled, that relate to the options chosen. It is working well, except that the boxplot and violin plots allow points to be added. When that checkbox is used, it is adding a jitter plot, so that option should then be enabled.
|
@rdstern This is ready for review. Thank you. |
|
@N-thony Kindly review the changes. Thank you |
|
@N-thony Thank you for reviewing. I have made the changes you requested. |
| If clsCurrGeomFunction.GetParameter("varwidth") IsNot Nothing Then | ||
| If clsCurrGeomFunction.GetParameter("varwidth").strArgumentValue = "TRUE" Then | ||
| End If | ||
| Else | ||
| 'chkVarwidth.Checked = False | ||
| End If |
There was a problem hiding this comment.
This code doesn't seem to do anything. Is it needed?
| sdgLayerOptions.ShowDialog() | ||
| bResetBoxLayerSubdialog = False | ||
| 'Coming from the sdgLayerOptions, clsRgeom_boxplot and others has been modified. One then needs to display these modifications on the dlgBoxPlot. | ||
| If clsCurrGeomFunction.GetParameter("varwidth") IsNot Nothing Then |
| 'This resets the factor receiver and causes it to be cleared of the correct variable. We don't want this. | ||
| 'ucrVariablesAsFactorForBoxplot.SetReceiverStatus() |
There was a problem hiding this comment.
delete?
| 'This resets the factor receiver and causes it to be cleared of the correct variable. We don't want this. | |
| 'ucrVariablesAsFactorForBoxplot.SetReceiverStatus() |
|
@N-thony is @EstherNjeriLiberatta available to address the comments above, or should we reassign? |
There was a problem hiding this comment.
This is much closer than the other version.
@N-thony please check whether @EstherNjeriLiberatta has the time to do this quickly. If not, then please re-allocate.
- Here is the current version in 0.7.7
Notice that the new version has lost the Add Points row of controls.
That should be returned.
And when it is ticked, then also enable Jitter as well as Box, because it is adding a layer
b) Add a Summary option into the pull-down. When the Groups to Connect is ticked, then stat-summary is enabled.
c) And change Box to Boxplot.
Fixes #7556
In this PR, I have replaced the
Box Optionsbutton in the Box plot dialogue with the newPlot Optionsbutton which includes a drop-down.@rdstern @africanmathsinitiative/developers This is ready for review.