Ensured that Default Column and Variable Name checkbox function correctly in New DataFrame dialog #8148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug found in the new dataframe dialogue
|
@derekagorhom while you are fixing that, I would like to explore with the |
…tem_TwoWay_Frequencies Output system two way frequencies
Test new dataframe
rdstern
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
@derekagorhom this looks absolutely fine. @lloyddewit over to you.
lloyddewit
changed the title
lloyddewit
approved these changes
Feb 21, 2023
|
@derekagorhom I am now unable to create a dataframe with less than 3 columns. Could you check that it wasn't this change that introduced this bug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8120
This is not ready for review as it needs further testing.
@N-thony , the fix works but it takes longer to load (probably from my laptop).
Also i found out that when you set the column to say 14 and reduce it to say 8, you get a column number between those 2 numbers.