Ensured that Bar Chart dialog opens with the correct settings, and improved formatting #8316

derekagorhom · 2023-05-09T10:52:07Z

Fixes partly #8288
This PR is ready for review
@rdstern i was able to fix items d, e, and g.
Item f will be fixed along with the new ones @COLIEWO found recently

COLIEWO

Items d,e and g look good.

derekagorhom · 2023-05-10T11:07:39Z

@COLIEWO , @rdstern the new changes solved the issues of item f and also the latest correction by celestine on vjust being changed from "5" to "1.5"

rdstern

@derekagorhom this is looking good. However, while you are there I looked at the translation into French. Adding better width of labels would be good at the same time.
And @MeSophie could you please edit the database to improve the translation of a Pie chart - which is Tart and should be Camembert and also Donut seems to be Anneau. @derekagorhom please make sure the labels have enough space for these.

@derekagorhom you see the Reorgansier la - that (In English) is Reorder Frequencies I suggest you get rif of the Frequencies here (Like the simple Reorder lower down. Then the French will automatically be complete/
Towards the bottom make the label wider for the Save control label - there is plenty of space.
For the Pie (Tart) just make sure that the label is wide enough for when Sophie has added the correct Camembert translation.

derekagorhom · 2023-05-15T11:09:13Z

@rdstern I have made layout changes you requested, but for Item a), @lloyddewit to make database change in the Id_text for it to be complete.
I have also increased the length of the pie and donut checkboxes

rdstern

@derekagorhom Here is a small problem, with the add.factor addition, so it can handle numeric data better.

# Code generated by the dialog, Bar Chart
diamonds <- data_book$get_data_frame(data_name="diamonds")
last_graph <- ggplot2::ggplot(diamonds, mapping=ggplot2::aes(x=forcats::fct_infreq(f=as.factor("carat")), fill="")) + ggplot2::geom_bar(stat="count") + theme_grey()
data_book$add_object(data_name="diamonds", object_name="last_graph", object_type_label="graph", object_format="image", object=check_graph(graph_object=last_graph))
data_book$get_object_data(data_name="diamonds", object_name="last_graph", as_file=TRUE)

In the code where you added as.factor, the variable is in quotes, here "carat". Please delete the quotes.

N-thony · 2023-05-15T13:48:23Z

instat/dlgBarAndPieChart.vb

+    Private Sub ucrPnlOptions_ControlValueChanged(ucrChangedControl As ucrCore) Handles ucrVariablesAsFactorForBarChart.ControlValueChanged, ucrReceiverX.ControlValueChanged, ucrReceiverLabel.ControlValueChanged, ucrReceiverByFactor.ControlValueChanged, ucrPnlOptions.ControlValueChanged, ucrNudMaxSize.ControlValueChanged, ucrInputReorderX.ControlValueChanged, ucrInputReorderValue.ControlValueChanged, ucrInputAddReorder.ControlValueChanged, ucrChkReorderValue.ControlValueChanged, ucrChkLollipop.ControlValueChanged, ucrChkIncreaseSize.ControlValueChanged, ucrChkAddLabelsText.ControlValueChanged
+
+    End Sub
+
+    Private Sub ucrReceiverByFactor_ControlContentsChanged(ucrChangedControl As ucrCore) Handles ucrReceiverByFactor.ControlContentsChanged, ucrPnlOptions.ControlContentsChanged
+
+    End Sub
+
+    Private Sub ucrReceiverX_ControlContentsChanged(ucrChangedControl As ucrCore) Handles ucrReceiverX.ControlContentsChanged
+
+    End Sub


there are no codes in those three subs can add the codes if needed otherwise remove them?

N-thony · 2023-05-15T13:52:42Z

instat/dlgBarAndPieChart.vb

@@ -807,7 +808,7 @@ Public Class dlgBarAndPieChart
                Case strDescending
                    clsBarAesFunction.AddParameter("fill", clsRFunctionParameter:=clsForecatsInfreqValue, iPosition:=1)
                Case strReverse
-                    clsForecatsReverseValue.AddParameter("f", ucrReceiverByFactor.GetVariableNames(False), iPosition:=0)
+                    clsForecatsReverseValue.AddParameter("f", ucrReceiverByFactor.GetVariableNames(False) & Chr(34), iPosition:=0)


in this line, are you trying to wrap the variable from the receiver with quotes?
my understanding from this line is if the variable name is for example x so you will have f = x", is that correct?

N-thony · 2023-05-15T14:02:46Z

instat/dlgBarAndPieChart.vb

+            clsForecatsInfreq.AddParameter("f", "as.factor(" & Chr(34) & ucrVariablesAsFactorForBarChart.GetVariableNames(False) & Chr(34) & ")", iPosition:=0)
+            clsForecatsInfreqValue.AddParameter("f", "as.factor(" & Chr(34) & ucrReceiverByFactor.GetVariableNames(False) & Chr(34) & ")", iPosition:=0)


.GetVariableNames as a parameter bWithQuotes a boolean where if true it will return the parameter name with quotes for example if the parameter is village you will have if .GetVariableNames(True) f = "village" and false if you don't want it with quotes

so, you can just have clsForecatsInfreq.AddParameter("f", "as.factor(" & ucrVariablesAsFactorForBarChart.GetVariableNames(False) & ")", iPosition:=0)

N-thony · 2023-05-16T07:19:53Z

@derekagorhom this is looking good. However, while you are there I looked at the translation into French. Adding better width of labels would be good at the same time. And @MeSophie could you please edit the database to improve the translation of a Pie chart - which is Tart and should be Camembert and also Donut seems to be Anneau. @derekagorhom please make sure the labels have enough space for these.

@derekagorhom you see the Reorgansier la - that (In English) is Reorder Frequencies I suggest you get rif of the Frequencies here (Like the simple Reorder lower down. Then the French will automatically be complete/

Towards the bottom make the label wider for the Save control label - there is plenty of space.

For the Pie (Tart) just make sure that the label is wide enough for when Sophie has added the correct Camembert translation.

@derekagorhom can you make the checkbox Réorganiser la wider so that it can fit the french text.

derekagorhom · 2023-05-16T08:06:44Z

@N-thony , @rdstern I have fixed problem with the quotes occurring in the script and also increased the width of the checkbox for reorder frequency
Thanks

N-thony · 2023-05-16T08:46:04Z

@N-thony , @rdstern I have fixed problem with the quotes occurring in the script and also increased the width of the checkbox for reorder frequency Thanks
@derekagorhom looks good now.

MeSophie · 2023-05-16T14:03:45Z

@N-thony I corrected the translation of Pie and Donut in Crowdin. And also corrected the translation of Experiments , I also wanted to change the translation of File to Fichier and not déposer (R-Instat Menu Items) but i received this notification. please can you have a look and approve the new translation? Thank you.

N-thony · 2023-05-17T07:12:36Z

@N-thony I corrected the translation of Pie and Donut in Crowdin. And also corrected the translation of Experiments , I also wanted to change the translation of File to Fichier and not déposer (R-Instat Menu Items) but i received this notification. please can you have a look and approve the new translation? Thank you.

@MeSophie everything is approved already, I think @lloyddewit need to merge the new PRs created to update the database with new translations.

rdstern

@derekagorhom well done - these now all seem to work. It would be good to merge. There will continue to be improvements, I am sure! Over to you @lloyddewit

lloyddewit · 2023-05-18T10:11:09Z

@MeSophie Thank you for the CrowdIn changes. I accepted/approved them all. I also changed File to Fichier. You should see your updated translations later today when I merge the updated Json files into the database.

instat/sdgPlots.vb

derekagorhom added 4 commits May 8, 2023 13:46

making Stack the default

e00a183

Added Fill_in_reverse

9c73add

Adding Factor to ascending and descending options

d27c008

Cosmetic Changes

aa3aefe

COLIEWO reviewed May 9, 2023

View reviewed changes

derekagorhom added 2 commits May 10, 2023 11:53

Removing "None" option from the legend position

76872c4

changing vjust from 5 to 1.5

7ab5d1d

rdstern requested changes May 15, 2023

View reviewed changes

Minor Changes

20ed150

rdstern requested changes May 15, 2023

View reviewed changes

derekagorhom added 3 commits May 16, 2023 08:48

Layout Changes

a2b6e69

Code Changes

fdb8ea9

Minor code changes

8c128c7

N-thony requested changes May 16, 2023

View reviewed changes

rdstern previously approved these changes May 18, 2023

View reviewed changes

lloyddewit changed the title ~~Fixed Bugs in the Bar chart dialogue~~ Ensured that Bar Chart dialog opens with the correct settings, and improved formatting May 18, 2023

lloyddewit added the bug label May 18, 2023

lloyddewit requested changes May 18, 2023

View reviewed changes

instat/sdgPlots.vb Outdated Show resolved Hide resolved

Update instat/sdgPlots.vb

cc51a25

lloyddewit dismissed rdstern’s stale review via cc51a25 May 18, 2023 10:14

lloyddewit approved these changes May 18, 2023

View reviewed changes

lloyddewit merged commit a6beeb4 into IDEMSInternational:master May 18, 2023

lloyddewit mentioned this pull request Jul 21, 2023

Fix two recent regressions on the graphics sub-dialog #8451

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensured that Bar Chart dialog opens with the correct settings, and improved formatting #8316

Ensured that Bar Chart dialog opens with the correct settings, and improved formatting #8316

derekagorhom commented May 9, 2023

COLIEWO left a comment

derekagorhom commented May 10, 2023

rdstern left a comment

derekagorhom commented May 15, 2023 •

edited

Loading

rdstern left a comment

N-thony May 15, 2023

N-thony May 15, 2023

N-thony May 15, 2023

N-thony commented May 16, 2023

derekagorhom commented May 16, 2023 •

edited

Loading

N-thony commented May 16, 2023

MeSophie commented May 16, 2023

N-thony commented May 17, 2023

rdstern left a comment

lloyddewit commented May 18, 2023

		clsForecatsInfreq.AddParameter("f", "as.factor(" & Chr(34) & ucrVariablesAsFactorForBarChart.GetVariableNames(False) & Chr(34) & ")", iPosition:=0)
		clsForecatsInfreqValue.AddParameter("f", "as.factor(" & Chr(34) & ucrReceiverByFactor.GetVariableNames(False) & Chr(34) & ")", iPosition:=0)

Ensured that Bar Chart dialog opens with the correct settings, and improved formatting #8316

Ensured that Bar Chart dialog opens with the correct settings, and improved formatting #8316

Conversation

derekagorhom commented May 9, 2023

COLIEWO left a comment

Choose a reason for hiding this comment

derekagorhom commented May 10, 2023

rdstern left a comment

Choose a reason for hiding this comment

derekagorhom commented May 15, 2023 • edited Loading

rdstern left a comment

Choose a reason for hiding this comment

N-thony May 15, 2023

Choose a reason for hiding this comment

N-thony May 15, 2023

Choose a reason for hiding this comment

N-thony May 15, 2023

Choose a reason for hiding this comment

N-thony commented May 16, 2023

derekagorhom commented May 16, 2023 • edited Loading

N-thony commented May 16, 2023

MeSophie commented May 16, 2023

N-thony commented May 17, 2023

rdstern left a comment

Choose a reason for hiding this comment

lloyddewit commented May 18, 2023

derekagorhom commented May 15, 2023 •

edited

Loading

derekagorhom commented May 16, 2023 •

edited

Loading