guard config in factory

afriendofmine · Dec 21, 2016 · 857a351 · 857a351
1 parent 8764bfa
commit 857a351
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/DeployNotifierServiceProvider.php b/src/DeployNotifierServiceProvider.php
@@ -22,7 +22,7 @@ public function register()
     {
         // bind DeployNotifierInterface
         $this->app->singleton(DeployNotifierInterface::class, function ($app) {
-            $deployNotifierFactory = new DeployNotifierFactory(config('deploy-notifier.notifiers'));
+            $deployNotifierFactory = new DeployNotifierFactory(config('deploy-notifier.notifiers', []));
 
             return $deployNotifierFactory->create(config('deploy-notifier.settings.notifier'));
         });

diff --git a/src/Factory/DeployNotifierFactory.php b/src/Factory/DeployNotifierFactory.php
@@ -43,8 +43,13 @@ public function create($type = '')
      */
     private function getHipChatNotifier()
     {
-        $roomId = $this->config['hipchat']['room_id'];
-        $token = $this->config['hipchat']['room_token'];
+        $roomId = '';
+        $token = '';
+
+        if (isset($this->config['hipchat'])) {
+            $roomId = $this->config['hipchat']['room_id'];
+            $token = $this->config['hipchat']['room_token'];
+        }
 
         $client = new Client(new OAuth2($token));