Callback for exitCode

[sarelvdwalt]

Addresses #11 to create a callback in userland for exitCodes returned by processes.

[sarelvdwalt]

The method chosen to do this was to add a configuration function setCompletedCallback. The way of using this is then:

$swarmProcess = new SwarmProcess($logger);
$swarmProcess->setCompletedCallback(function(Symfony\Component\Process\Process $process) {
    // do something with the $process returned, checking it's exit code, and perhaps putting it back on the stack
});

[sarelvdwalt]

@mostertb and @johnathanmdell would you mind having a look and telling me what your thoughts are?

[johnathanmdell]

@sarelvdwalt I'm happy with that, nothing overly complicated to achieve some simple communication between the child and parent.

👍

[mostertb]

@sarelvdwalt This looks great!
Its something that I've personally very much wanted. Thank you

Two things:

1. Will you update the README.md with this new functionality?
2. If running in a loop with $swarm->tick(), the callback could theoretically be changed mid-execution. Is this something we intend to support?

[sarelvdwalt]

@sarelvdwalt This looks great!
Its something that I've personally very much wanted. Thank you

Two things:

1. Will you update the README.md with this new functionality?
2. If running in a loop with $swarm->tick(), the callback could theoretically be changed mid-execution. Is this something we intend to support?

Thanks @mostertb

1. Ok will do and notify
2. Not sure, didn't think about this - I see no reason why not to allow this, other than protecting the user from themselves. I think we should leave this open.

[sarelvdwalt]

@mostertb I have updated the documentation.

[sarelvdwalt]

@mostertb and @johnathanmdell I have now moved the callback to the Configuration object. This object creation is also to plan for the future change planned for a setting to respect Process timeout settings.