Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race descriptions are differently sized compared to vanilla #114

Open
Thunderforge opened this issue Mar 8, 2018 · 5 comments
Open

Race descriptions are differently sized compared to vanilla #114

Thunderforge opened this issue Mar 8, 2018 · 5 comments
Labels

Comments

@Thunderforge
Copy link
Collaborator

Thunderforge commented Mar 8, 2018

In vanilla, the race descriptions appear like this:

redguard vanilla

However in OpenTESArena, it appears like this:

reguard opentesarena

You'll notice that there is a lot more whitespace in the second picture than the first one, that it covers more of the map, and that the last line is considerably longer than the first.

This is the only description where I could tell a difference. All of the other descriptions (e.g. the player's class) appear to be the same size as vanilla.

@afritz1
Copy link
Owner

afritz1 commented Mar 8, 2018

I remember talking about this on Discord (Jan. 27th). Summarized for brevity:

Thunderforge: Quick question: are you looking for pixel-perfect compatibility in the menus? I noticed that the race description isn't the right size compared the the original

Me: OpenTESArena is currently displaying the texts as they are stored in the data, but I guess it needs to change to some max character limit per line at some point.
It's not a bug; it's just another one of those quirks of Arena where it doesn't actually use the data as-is.

Thunderforge: Should I raise an issue on the GitHub page?

Me: whether or not you create an issue is fine. It's just low priority right now.

My thoughts haven't changed yet. I'm assuming Arena defines some integer for "max line width" somewhere, but I don't know anything more on the subject.

@Thunderforge
Copy link
Collaborator Author

Thunderforge commented Mar 8, 2018

Totally fine with it being low priority. I just realized today that I still had the screenshots around, but never got around to reporting it.

@Carmina16
Copy link
Collaborator

This particular dialog is wrapped at 40 characters (the default value is 60).

@afritz1
Copy link
Owner

afritz1 commented Mar 8, 2018

This particular dialog is wrapped at 40 characters (the default value is 60).

Thanks. I will put this on the to-do list, along with the text box refactor and support for tab-specified colors.

@afritz1 afritz1 added this to the 0.8.0 milestone May 25, 2018
@afritz1 afritz1 removed this from the 0.8.0 milestone Aug 18, 2018
@afritz1
Copy link
Owner

afritz1 commented Oct 10, 2018

Commit 02e2bb6 makes some progress on fixing this issue. It is almost there now, maybe one character off. I'm not exactly sure how the wrapping is done yet.

@afritz1 afritz1 added this to the 0.9.0 milestone Oct 21, 2018
@afritz1 afritz1 modified the milestones: 0.10.0, 0.11.0 Sep 12, 2019
@afritz1 afritz1 removed this from the 0.11.0 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants