Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip: should use x-forwarded-for #42

Closed
syndr0m opened this issue Feb 16, 2016 · 1 comment
Closed

ip: should use x-forwarded-for #42

syndr0m opened this issue Feb 16, 2016 · 1 comment
Labels

Comments

@syndr0m
Copy link
Contributor

syndr0m commented Feb 16, 2016

userIp should be:

  • x-forwarded-for => remove rfc 1918 address => read leftmost ip
  • if (empty string) => req.ip
@syndr0m
Copy link
Contributor Author

syndr0m commented Feb 16, 2016

70a09bb

@syndr0m syndr0m closed this as completed Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant