EIT-2304: Feature - Cash App Orders #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronveloso
requested changes
Feb 16, 2023
afterpay/src/main/kotlin/com/afterpay/android/cashapp/AfterpayCashAppApi.kt
Outdated
Show resolved
Hide resolved
afterpay/src/main/kotlin/com/afterpay/android/cashapp/AfterpayCashAppApi.kt
Outdated
Show resolved
Hide resolved
afterpay/src/main/kotlin/com/afterpay/android/AfterpayEnvironment.kt
Outdated
Show resolved
Hide resolved
afterpay/src/main/kotlin/com/afterpay/android/cashapp/AfterpayCashApp.kt
Outdated
Show resolved
Hide resolved
example/src/main/kotlin/com/example/afterpay/checkout/CheckoutFragment.kt
Outdated
Show resolved
Hide resolved
example/src/main/kotlin/com/example/afterpay/data/CheckoutRequest.kt
Outdated
Show resolved
Hide resolved
example/src/main/kotlin/com/example/afterpay/receipt/CashReceiptFragment.kt
Outdated
Show resolved
Hide resolved
Adding Dev Options menu for easier dev and QA
…ndroid into feature/EIT-2304-cash-app
…vements EIT-2304: cash request function improvements
1 task
…d-clarity EIT-2304: make cash token signing method more clear
pedronveloso
approved these changes
Mar 2, 2023
Comment on lines
+25
to
+29
| every { connection.requestMethod = "POST" } returns Unit | ||
| every { connection.doInput = true } returns Unit | ||
| every { connection.doOutput = true } returns Unit | ||
| every { connection.setRequestProperty(any(), any()) } returns Unit | ||
| every { connection.outputStream } returns ByteArrayOutputStream() |
There was a problem hiding this comment.
Nit: I wonder if we used relaxed = true when defining the mock above, if we would still need to define all of this "stubs". Might be worth trying if that works, if so could remove this entire block on the setup.
eg.: private val connection = mockk<HttpsURLConnection>(relaxed = true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes