add option to query multiple characters by multiple ids in GraphQL #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ey-Jay
changed the title
|
Hey @Ey-Jay that looks great, thank you!! It would be great if you can implement the same for |
afuh
requested changes
Aug 20, 2020
graphql/sources.js
Outdated
|
|
||
| async charactersByIds({ ids }) { | ||
| const data = await this.get('/' + ids) | ||
| return data |
There was a problem hiding this comment.
If you use characterByIds with an array of one id, you will get an error because the API is going to return a single character.
You need to return an array, you should add this:
return Array.isArray(data) ? data : [data]
There was a problem hiding this comment.
You are right. I missed that one. Changes added 👨🏼🎤
|
Great stuff! thank you! |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to provide the same feature currently available in the REST API ex.
https://rickandmortyapi.com/api/character/1,2,3closes #89