-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign recursions #21
Comments
A better design for this situation, in general, is to use a while loop that repeats until the condition is passed (success) or some threshold number of loops has been exceeded (failure, throw exception). Depending on the circumstances, we could then handle the exception or have a hard failure. For debugging, this value could be smaller. Once debugging is finished, the threshold would be increased to a larger value. |
The first task for this issue is to identify the places where this design is used, and insert a FIXME comment. |
…d with issue #21 because running the statconc scripts resulted in this error
qhmm_family is the only script left that does a recursion |
Have the unit tests for the modified class been checked? |
It is reasonable to postpone the modification of qhmm_family until we need it. Let's leave this issue open however. |
Yes, the unit tests have been checked. |
There are some methods which call themselves when an error occurs. The idea was that certain undesirable cases from random sampling would be avoided by resampling until a condition was passed. However, this design is difficult for development because exceptions caused by bugs keep recurring on repeated trials, leading to stack overflow.
The text was updated successfully, but these errors were encountered: